A prominent stock-market analyst throws in the towel as the S&P 500 index nears his end-of-decade target with “eight-and-a-half years to go,” writing that he now agrees with colleagues that the U.S. benchmark could hit 8,000 by 2030.